17
The day I realized my 'helpful' advice was just mansplaining code reviews
About 2 months back I was reviewing a junior dev's pull request on our team's React app. I started typing out this long comment about how they should restructure their component. Then I paused and actually looked at what they built. It worked fine. It was clean. I was just mad they didn't do it MY way. What tipped me off was when another senior dev replied with just "looks good" and approved it. Made me wonder how many times I've been that guy. Has anyone else caught themselves critiquing just to feel useful?
3 comments
Log in to join the discussion
Log In3 Comments
mason_lopez1mo ago
Think that applies more to people giving unsolicited advice than code reviews.
7
cora5181mo ago
That phrase "need to feel needed" really sticks with me. I had a neighbor who would always jump in to "help" people carry groceries even when they clearly had it handled. It was like he got uncomfortable if someone wasn't relying on him for something, even if it was just holding a door. Makes me wonder if some people just don't know how to be around others without offering help nobody asked for. Do you think it's harder for some folks to just sit back and watch?
-1