A senior dev's comment about my commit messages fixed my whole workflow

So back in March I was working on a project in Austin and a senior dev pulled me aside after a code review. He said "your commits read like you're hiding something" because I was writing stuff like "fix stuff" and "updated file". At first I was annoyed but then I looked at my history and he was right. I started writing commits that explain the why not just the what, like "remove unused imports to speed up build time by 4 seconds". Now when I look back at my own work from 6 months ago I can actually remember what I was thinking. Has anyone else gotten feedback that seemed petty but turned out to be the most useful advice you got that year?

1 comments

1 Comment

victor77922d ago

You ever get feedback that stings so bad you end up telling the whole team about it later? That happened to me with naming variables, someone said mine looked like I was trying to lose a game of charades. Now I just name things what they are, even if it's boring, and honestly my code reviews got way less awkward. Funny how the harsh stuff sticks around and actually ends up being the thing you pass on to new people.